deemoliu edited a comment on pull request #8108:
URL: https://github.com/apache/pinot/pull/8108#issuecomment-1029430404


   > `nums of records` itself should be the `unqiue Keycombination`. The 
formula can be simplified
   
   Thanks @Jackie-Jiang for review. 
   
   I added another optional parameter for `primary key cardinality`.
   If primary key cardinality parameter is provided, the command can use 
primary key cardinality as unqiue Keycombination and the simplified formula to 
calculate the estimated key space and value space.
   if primary key cardinality parameter is not provide, the command will 
calculate the unique key combination based on message rate, append frequency 
(nums of record, skipUpsert records), etc.. 
   
   We want to use the tool on staging table which has fewer records, so the 
nums of records here might not reflect to the unique key combinations in prod 
table with longer retention. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to