dongxiaoman opened a new pull request #8193: URL: https://github.com/apache/pinot/pull/8193
## Description <!-- Add a description of your PR here. A good description should include pointers to an issue or design document, etc. --> Enable controller service auto-discovery in Jersey framework. This is following https://github.com/apache/pinot/pull/8107 to enable the service auto-creation in controller too. It is found out that we may need to hook in new services in Pinot Controllers too. The context can be found in previous PR, I will copy/paste the same text here for reference: 1. Main idea is behind [mkyong's article in detail in here](https://mkyong.com/webservices/jax-rs/jersey-and-hk2-dependency-injection-auto-scanning/) 2. Added a property boolean named `pinot.controller.service.auto.discovery` to enable this behavior Steps needed to make a class auto-created in PinotController: 1. Add `hk2-metadata-generator` module as a dependency in your JAR file 2. Tag your class with `@org.jvnet.hk2.annotations.Service` tag 3. Set `pinot.controller.service.auto.discovery=true` in your Controller's property config 4. Make sure your JAR file is loaded in class path(of coz) 5. (Optional) inject your class instance to other places ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) - New configuration options: `pinot.controller.service.auto.discovery` so Jersey services can be created automatically and then later injected to Endpoints. * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
