npawar commented on pull request #8243:
URL: https://github.com/apache/pinot/pull/8243#issuecomment-1049531229


   > Because I see the changes will only affect the `_ingestionSchemaValidator` 
within `SegmentIndexCreationDriverImpl` which has no usages, and some data 
generation tools.
   
   Also I don't see how this change is helping. Comment from above: `Because I 
see the changes will only affect the _ingestionSchemaValidator within 
SegmentIndexCreationDriverImpl which has no usages, and some data generation 
tools.` 
   Is this the main line of change in this PR? Everything else doesn't seem 
relevant.
   ```
   if (dest != PinotDataType.JSON) {
             value = standardize(column, value, dest.isSingleValue());
           }
   ```
   And you shouldn't need this with jsonFormat.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to