Jackie-Jiang commented on a change in pull request #8304:
URL: https://github.com/apache/pinot/pull/8304#discussion_r826407640
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java
##########
@@ -392,6 +431,45 @@ public static String normalize(String input, String form) {
return StringUtils.split(input, delimiter);
}
+ /**
+ * see String#split(String)
+ * @param input
+ * @param delimiter
+ * @return splits string on specified delimiter and returns an array.
+ */
+ @ScalarFunction
+ public static String split(String input, String delimiter, int index) {
Review comment:
I see, let's keep the start index as 0.
I'd suggest adding it as `splitPart` so that it does not collide with
`split` with limit. We can also add a `split` with 3 arguments which returns
`StringUtils.split(input, delimiter, limit)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
