siddharthteotia commented on a change in pull request #8381:
URL: https://github.com/apache/pinot/pull/8381#discussion_r832525026



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java
##########
@@ -478,6 +490,25 @@ public synchronized void refreshSegment(String segment) {
     return res;
   }
 
+  /**
+   * Returns the complement (non-overlapping sorted intervals) of the given 
non-overlapping sorted intervals.
+   */
+  private List<Interval> getComplementSortedIntervals(List<Interval> 
intervals) {

Review comment:
       (nit) might want to add a unit test just for this function alone ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to