This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2d5cbf7 Change default memory allocation for consuming segments from
on-heap to off-heap. (#8380)
2d5cbf7 is described below
commit 2d5cbf726730fc8c148212aeb8c8d158ce84a7d1
Author: Mayank Shrivastava <[email protected]>
AuthorDate: Tue Mar 22 12:38:40 2022 -0700
Change default memory allocation for consuming segments from on-heap to
off-heap. (#8380)
It has been observed as well as established across several production
deployments
that allocating consuming segments off-heap is better than allocating
on-heap.
- Modifying the default value of
`pinot.server.instance.realtime.alloc.offheap` to true.
- Note, that the default off-heap setting implies MMAP, and we still
require setting
`pinot.server.instance.realtime.alloc.offheap.direct` to true if using
DirectMemory
is preferred over MMAP.
---
.../pinot/server/starter/helix/HelixInstanceDataManagerConfig.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
index 74aa5fc..809a866 100644
---
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
+++
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
@@ -184,7 +184,7 @@ public class HelixInstanceDataManagerConfig implements
InstanceDataManagerConfig
@Override
public boolean isRealtimeOffHeapAllocation() {
- return
_instanceDataManagerConfiguration.getProperty(REALTIME_OFFHEAP_ALLOCATION,
false);
+ return
_instanceDataManagerConfiguration.getProperty(REALTIME_OFFHEAP_ALLOCATION,
true);
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
