Jackie-Jiang commented on a change in pull request #8407:
URL: https://github.com/apache/pinot/pull/8407#discussion_r834832936
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -75,7 +75,7 @@ public NormalizedDateSegmentNameGenerator(String tableName,
@Nullable String seg
// Parse input time format: 'EPOCH' or 'SIMPLE_DATE_FORMAT' using pattern
Review comment:
Also update the comment
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -735,7 +735,8 @@ public static DateTimeFieldSpec
convertToDateTimeFieldSpec(TimeFieldSpec timeFie
String outgoingTimeFormat = outgoingGranularitySpec.getTimeFormat();
String[] split = StringUtils.split(outgoingTimeFormat,
DateTimeFormatSpec.COLON_SEPARATOR, 2);
DateTimeFormatSpec formatSpec;
- if (split[0].equals(DateTimeFieldSpec.TimeFormat.EPOCH.toString())) {
+ if (split[0].equals(DateTimeFieldSpec.TimeFormat.EPOCH.toString()) ||
split[0].equals(
Review comment:
This is for the deprecated `TimeFieldSpec` which does not have the
`TIMESTAMP` support. No need to change this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
