jackjlli commented on a change in pull request #8441:
URL: https://github.com/apache/pinot/pull/8441#discussion_r839292161
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java
##########
@@ -58,25 +60,37 @@
@JsonIgnoreProperties(ignoreUnknown = true)
public class InstancePartitions {
private static final char PARTITION_REPLICA_GROUP_SEPARATOR = '_';
+ private static final String PARTITIONS_KEY = "partitions";
+ private static final String INSTANCE_SEPARATOR = "/";
private final String _instancePartitionsName;
- private final Map<String, List<String>> _partitionToInstancesMap;
+ private final Map<String, List<String>>
_partitionWithReplicaGroupToInstancesMap;
+ private final Map<Integer, List<String>> _partitionToInstancesMap;
Review comment:
I did think about reusing the existing InstancePartitions from ZNode,
but the problem is that there is no way to know about the pool information of
an instance if its instance config is gone from the cluster; we don't know
which pool the gone instance belongs to, so we don't know which pool we should
pick the new instance from.
On the other hand, since we can choose which table should we enable this
feature, the overhead on the ZNode should be controllable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
