richardstartin commented on a change in pull request #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r839477249
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java ########## @@ -170,17 +171,12 @@ public void init(SegmentGeneratorConfig segmentCreationSpec, SegmentIndexCreatio Preconditions.checkState(dictEnabledColumn || !invertedIndexColumns.contains(columnName), "Cannot create inverted index for raw index column: %s", columnName); - IndexCreationContext.Common context = IndexCreationContext.builder() - .withIndexDir(_indexDir) - .withCardinality(columnIndexCreationInfo.getDistinctValueCount()) - .withDictionary(dictEnabledColumn) - .withFieldSpec(fieldSpec) - .withTotalDocs(segmentIndexCreationInfo.getTotalDocs()) + IndexCreationContext.Common context = IndexCreationContext.builder().withIndexDir(_indexDir) + .withCardinality(columnIndexCreationInfo.getDistinctValueCount()).withDictionary(dictEnabledColumn) + .withFieldSpec(fieldSpec).withTotalDocs(segmentIndexCreationInfo.getTotalDocs()) .withTotalNumberOfEntries(columnIndexCreationInfo.getTotalNumberOfEntries()) - .withColumnIndexCreationInfo(columnIndexCreationInfo) - .sorted(columnIndexCreationInfo.isSorted()) - .onHeap(segmentCreationSpec.isOnHeap()) - .build(); Review comment: if you rebase @xiangfu0 has updated the formatter to leave line-per-method builder invocations alone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org