jasperjiaguo commented on a change in pull request #8036: URL: https://github.com/apache/pinot/pull/8036#discussion_r839895888
########## File path: pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java ########## @@ -72,16 +75,44 @@ public void setExpectedResultsFileName(String expectedResultsFileName) { _expectedResultsFileName = expectedResultsFileName; } + public Boolean getShouldCompareNumEntriesScannedInFilter() { + return _shouldCompareNumEntriesScannedInFilter; + } + + public void setShouldCompareNumEntriesScannedInFilter(Boolean shouldCompareNumEntriesScannedInFilter) { + _shouldCompareNumEntriesScannedInFilter = shouldCompareNumEntriesScannedInFilter; + } + + public Boolean getShouldCompareNumConsumingSegmentsQueried() { + return _shouldCompareNumConsumingSegmentsQueried; + } + + public void setShouldCompareNumConsumingSegmentsQueried(boolean shouldCompareNumConsumingSegmentsQueried) { + _shouldCompareNumConsumingSegmentsQueried = shouldCompareNumConsumingSegmentsQueried; + } + + public Boolean getShouldRunAllGenerations() { + return _shouldRunAllGenerations; + } + + public void setShouldRunAllGenerations(Boolean shouldRunAllGenerations) { + _shouldRunAllGenerations = shouldRunAllGenerations; + } + @Override boolean runOp(int generationNumber) { System.out.println("Verifying queries in " + _queryFileName + " against results in " + _expectedResultsFileName); try { - for (int i = 1; i <= generationNumber; i++) { - if (!verifyQueries(i)) { - return false; + if (getShouldRunAllGenerations()) { Review comment: Got it. Thanks for pointing out. Then for the index/partition validation relying on the metadata there should be some re-design. I have something in mind and is working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org