richardstartin commented on a change in pull request #8443:
URL: https://github.com/apache/pinot/pull/8443#discussion_r840059632
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/trace/TraceContextTest.java
##########
@@ -102,19 +102,21 @@ public void runJob() {
for (Future future : futures) {
future.get();
}
-
+ // to check uniqueness of traceIds
+ Set<String> traceIds = new HashSet<>();
Queue<TraceContext.Trace> traces =
TraceContext.REQUEST_TO_TRACES_MAP.get(requestId);
Assert.assertNotNull(traces);
Assert.assertEquals(traces.size(), NUM_CHILDREN_PER_REQUEST + 1);
for (TraceContext.Trace trace : traces) {
// Trace Id is not deterministic because it relies on the order of
runJob() getting called
List<TraceContext.Trace.LogEntry> logs = trace._logs;
+ traceIds.add(trace._traceId);
Assert.assertEquals(logs.size(), requestId + 1);
for (TraceContext.Trace.LogEntry log : logs) {
Assert.assertTrue(expectedTraces.contains(log.toJson().toString()));
}
}
-
+ Assert.assertEquals(traceIds.size(), NUM_CHILDREN_PER_REQUEST + 1);
Review comment:
👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
