walterddr commented on a change in pull request #8412: URL: https://github.com/apache/pinot/pull/8412#discussion_r840949126
########## File path: pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/DataTableBlock.java ########## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.blocks; + +import java.io.IOException; +import org.apache.pinot.common.utils.DataTable; +import org.apache.pinot.core.common.Block; +import org.apache.pinot.core.common.BlockDocIdSet; +import org.apache.pinot.core.common.BlockDocIdValueSet; +import org.apache.pinot.core.common.BlockMetadata; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.operator.blocks.InstanceResponseBlock; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * A {@code DataTableBlock} is a row-based data block backed by a {@link DataTable}. + */ +public class DataTableBlock implements Block { Review comment: we should probably estimate whether it is better to send data over the wire using columnar format 1. there's tradeoff when encoding data in row vs. columnar format when key-partitioned block split operation is done (for example distributed hash-join) 2. there's tradeoff when data arrived at the receiving end and being processed (obviously columnar format wins in many of the situation) in this case let's come up with a columnar format as well as a row-based format (for the data block sent over mailbox) because if columnar format turns up performing better, we don't need to reinvent a row-base operator code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
