KKcorps commented on code in PR #8398: URL: https://github.com/apache/pinot/pull/8398#discussion_r842542474
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ########## @@ -53,6 +53,8 @@ private SegmentPartitionConfig _segmentPartitionConfig; private boolean _aggregateMetrics; private boolean _nullHandlingEnabled; + private boolean _optimizeDictionaryEnabled; + private double _thresholdMinPercentDictionaryStorageSaved; Review Comment: No, we are not changing that. @Jackie-Jiang the default value doesn't make sense to me based on the current formula. We are creating dictionaries by default and the logic only avoid creating it when we can save some significant storage. If a column is set as rawValueColumn then no dictionary will be created, irrespective of the logic here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
