PrachiKhobragade commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r851531894
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -2152,8 +2159,16 @@ static void validateRequest(PinotQuery pinotQuery, int
queryResponseLimit) {
throw new IllegalStateException("SQL query should always have response
format and group-by mode set to SQL");
}
+ // throw errors if options is less than 1, rectify if larger that current
replicas
+ if (queryOptions.get(Broker.Request.QueryOptionKey.NUM_REPLICA_GROUPS) !=
null) {
Review Comment:
Also If we do this in select, we will have to store tableConfig in
instanceSelector to get the correct number of replicas or pass that as an extra
information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
