saurabhd336 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r852613339
##########
pinot-spi/pom.xml:
##########
@@ -149,6 +149,20 @@
<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
Review Comment:
No real HTTP call happening here actually. Only needed for `URIBuilder` util
class.
` URIBuilder uriBuilder = new
URIBuilder().setScheme(schema).setHost(hostPort).setPath(path);
for (Map.Entry<String, String> entry : params.entrySet()) {
uriBuilder.addParameter(entry.getKey(), entry.getValue());
}
try {
return uriBuilder.build();
} catch (Exception e) {
throw new RuntimeException(e);
}`
In URIUtils.java
Did not make changes to file themselves, only moved to new package. Hence
these dependencies needed. We could change the URI creation logic to get rid of
these heavy dependencies just for the util class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
