walterddr commented on code in PR #8557:
URL: https://github.com/apache/pinot/pull/8557#discussion_r853170025
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -107,6 +108,40 @@ private static String removeTerminatingSemicolon(String
sql) {
return sql;
}
+ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
+ throws Exception {
+ // Remove the comments from the query
+ sql = removeComments(sql);
+
+ // Remove the terminating semicolon from the query
+ sql = removeTerminatingSemicolon(sql);
+
+ // Extract OPTION statements from sql as Calcite Parser doesn't parse it.
+ List<String> options = extractOptionsFromSql(sql);
Review Comment:
this can be cleaned up by extending parser.jj to allow `OPTION` keyword but
that can be done later.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -197,6 +206,29 @@ public void processSqlQueryPost(String query, @Suspended
AsyncResponse asyncResp
}
}
+ private BrokerResponse executeSqlQuery(ObjectNode sqlRequestJson,
HttpRequesterIdentity httpRequesterIdentity)
+ throws Exception {
+ SqlNodeAndOptions sqlNodeAndOptions;
+ try {
+ sqlNodeAndOptions =
CalciteSqlParser.compileToSqlNodeAndOptions(sqlRequestJson.get(Request.SQL).asText());
+ } catch (Exception e) {
+ return new
BrokerResponseNative(QueryException.getException(QueryException.PQL_PARSING_ERROR,
e));
+ }
+ PinotSqlType sqlType =
CalciteSqlParser.extractSqlType(sqlNodeAndOptions.getSqlNode());
+ switch (sqlType) {
+ case DQL:
+ return _requestHandler.handleRequest(sqlRequestJson,
httpRequesterIdentity, new RequestStatistics());
Review Comment:
this means all parsing done so far is not used, instead sending the stuff to
broker and parse it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
