siddharthteotia commented on code in PR #8558:
URL: https://github.com/apache/pinot/pull/8558#discussion_r855387615
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/nodes/MailboxSendNode.java:
##########
@@ -18,21 +18,35 @@
*/
package org.apache.pinot.query.planner.nodes;
+import javax.annotation.Nullable;
import org.apache.calcite.rel.RelDistribution;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.pinot.query.planner.nodes.serde.ProtoProperties;
+import org.apache.pinot.query.planner.partitioning.KeySelector;
public class MailboxSendNode extends AbstractStageNode {
+ @ProtoProperties
private int _receiverStageId;
+ @ProtoProperties
private RelDistribution.Type _exchangeType;
+ @ProtoProperties
+ private KeySelector<Object[], Object> _partitionKeySelector;
public MailboxSendNode(int stageId) {
- super(stageId);
+ super(stageId, null);
Review Comment:
Is this null because we don't know upfront at the time of stage plan
creation ? I think this information should be available ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
