saurabhd336 commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r855764190
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##########
@@ -71,12 +88,53 @@ private JsonUtils() {
public static final ObjectReader DEFAULT_READER = DEFAULT_MAPPER.reader();
public static final ObjectWriter DEFAULT_WRITER = DEFAULT_MAPPER.writer();
public static final ObjectWriter DEFAULT_PRETTY_WRITER =
DEFAULT_MAPPER.writerWithDefaultPrettyPrinter();
+ private static final TypeReference<HashMap<String, Object>>
GENERIC_JSON_TYPE =
+ new TypeReference<HashMap<String, Object>>() { };
public static <T> T stringToObject(String jsonString, Class<T> valueType)
throws IOException {
return DEFAULT_READER.forType(valueType).readValue(jsonString);
}
+ public static <T> JsonPojoWithUnparsableProps<T>
stringToObjectAndUnparseableProps(String jsonString, Class<T> klass)
Review Comment:
Ack on https://github.com/apache/pinot/pull/8514/files#r855450400
[#2](https://github.com/apache/pinot/pull/8514/files#r855451277) The Pair
class defined within the project expects 'T' to be extending Serializable,
which would mean changing the base response classes. Other Pair implementations
would need dependencies. Leaving it as it is for now.. Will revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
