yupeng9 commented on code in PR #8590:
URL: https://github.com/apache/pinot/pull/8590#discussion_r859151636
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -103,13 +103,14 @@ public void addSegment(IndexSegment segment,
Iterator<RecordInfo> recordInfoIter
(primaryKey, currentRecordLocation) -> {
if (currentRecordLocation != null) {
// Existing primary key
+ IndexSegment currentSegment = currentRecordLocation.getSegment();
+ int comparisonResult =
recordInfo._comparisonValue.compareTo(currentRecordLocation.getComparisonValue());
Review Comment:
I see. makes sense.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -103,13 +103,14 @@ public void addSegment(IndexSegment segment,
Iterator<RecordInfo> recordInfoIter
(primaryKey, currentRecordLocation) -> {
if (currentRecordLocation != null) {
// Existing primary key
+ IndexSegment currentSegment = currentRecordLocation.getSegment();
+ int comparisonResult =
recordInfo._comparisonValue.compareTo(currentRecordLocation.getComparisonValue());
Review Comment:
curious, which particular line caused the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
