npawar commented on code in PR #8582:
URL: https://github.com/apache/pinot/pull/8582#discussion_r862255492
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/InbuiltFunctionEvaluator.java:
##########
@@ -68,17 +69,27 @@ private ExecutableNode planExecution(ExpressionContext
expression) {
childNodes[i] = planExecution(arguments.get(i));
}
String functionName = function.getFunctionName();
- FunctionInfo functionInfo =
FunctionRegistry.getFunctionInfo(functionName, numArguments);
- if (functionInfo == null) {
- if (FunctionRegistry.containsFunction(functionName)) {
- throw new IllegalStateException(
- String.format("Unsupported function: %s with %d parameters",
functionName, numArguments));
- } else {
- throw new IllegalStateException(
- String.format("Unsupported function: %s not found",
functionName));
- }
+ switch (functionName) {
+ case "and":
Review Comment:
need to make sure these work case-insensitive way (all other scalar
functions do)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
