Jackie-Jiang commented on code in PR #7358:
URL: https://github.com/apache/pinot/pull/7358#discussion_r868285744
##########
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##########
@@ -107,4 +122,25 @@ protected Object convertRecord(Object value) {
}
return convertedMap;
}
+
+ /**
+ * This method convert any Avro logical-type converted (or not) value to a
class supported by
+ * Pinot {@link GenericRow}
+ *
+ * Note that at the moment BigDecimal is converted to Pinot double which may
lead to precision loss or may not be
+ * represented at all.
+ * Similarly, timestamp microsecond precision is not supported at the
moment. These values will get converted to
+ * millisecond precision.
+ */
+ @Override
+ protected Object convertSingleValue(Object value) {
+ if (value instanceof BigDecimal) {
Review Comment:
We recently added big-decimal support in #8503, so here we should just
return `BigDecimal` as is (no need to have this special handling. The base
implementation can handle it properly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
