atris commented on PR #8636: URL: https://github.com/apache/pinot/pull/8636#issuecomment-1121792892
@Jackie-Jiang Updated the PR. Regards to the Analyser, I looked at the core Lucene class and also did some benchmarking -- due to the fact that only one thread is writing to a single mutable FST at any given point of time, I was not able to see any significant overhead due to the analyser refresh. However, I have attuned the code now per your comments. Also, regards to the exceptions, I have been actively trying to limit the exceptions raised to the ones which are significant to the index -- for eg, I do not feel its worth failing the test if a thread is interrupted, or the Lucene SearcherManager failed to refresh. However, again, I have attuned the code now per your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
