noon-stripe commented on code in PR #8611:
URL: https://github.com/apache/pinot/pull/8611#discussion_r875045890
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -533,6 +556,37 @@ private void addNewRow(int docId, GenericRow row) {
String column = entry.getKey();
IndexContainer indexContainer = entry.getValue();
+ // aggregate metrics is enabled.
+ if (indexContainer._valueAggregator != null) {
+ Object value = row.getValue(indexContainer._sourceColumn);
+
+ // Update numValues info
+ indexContainer._numValuesInfo.updateSVEntry();
+
+ MutableForwardIndex forwardIndex = indexContainer._forwardIndex;
+ FieldSpec fieldSpec = indexContainer._fieldSpec;
+
+ DataType dataType = fieldSpec.getDataType();
+ value =
indexContainer._valueAggregator.getInitialAggregatedValue(value);
+ switch (dataType.getStoredType()) {
+ case INT:
+ forwardIndex.setInt(docId, ((Number) value).intValue());
+ break;
+ case LONG:
+ forwardIndex.setLong(docId, ((Number) value).longValue());
+ break;
+ case FLOAT:
+ forwardIndex.setFloat(docId, ((Number) value).floatValue());
+ break;
+ case DOUBLE:
+ forwardIndex.setDouble(docId, ((Number) value).doubleValue());
+ break;
+ default:
+ throw new UnsupportedOperationException(
+ "Unsupported data type: " + dataType + " for aggregation: " +
column);
+ }
Review Comment:
yes
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -610,9 +664,13 @@ private void addNewRow(int docId, GenericRow row) {
"Unsupported data type: " + dataType + " for no-dictionary
column: " + column);
}
+ if (column.equals("*")) {
Review Comment:
nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
