saurabhd336 commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r875611306
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -215,6 +237,22 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
dictionaryCreator.getNumBytesPerEntry());
throw e;
}
+
+ if (bloomFilterColumns.contains(columnName)) {
Review Comment:
I'm not too sure, but looks like bloom filter only gets created for columns
where dictionary encoding is enabled
https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java#L142?
https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java#L111
Also this docs says bloom filters are only supported on dictionary encoded
columns?
https://docs.pinot.apache.org/basics/indexing/bloom-filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
