navina commented on code in PR #8732:
URL: https://github.com/apache/pinot/pull/8732#discussion_r876321094
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/GroovyFunctionEvaluator.java:
##########
@@ -86,10 +86,6 @@ public List<String> getArguments() {
public Object evaluate(GenericRow genericRow) {
for (String argument : _arguments) {
Object value = genericRow.getValue(argument);
- if (value == null) {
Review Comment:
What is the behavior if the provided function doesn't handle `null` values?
it might throw exception and is that handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
