gortiz commented on PR #8766: URL: https://github.com/apache/pinot/pull/8766#issuecomment-1138721759
I've just removed the usage of VarHandle as it was quite messy to make it work with Java 8 and 11. The performance difference is not significant, so we may try to use VarHandle in future, but doesn't seem to have high priority. ``` Benchmark (_numRows) (_numSegments) Mode Cnt Score Error Units BenchmarkColumnValueSegmentPruner.query 10 10 avgt 5 0.800 ± 0.016 us/op BenchmarkColumnValueSegmentPruner.query 10 100 avgt 5 5.974 ± 0.047 us/op BenchmarkColumnValueSegmentPruner.query 10 1000 avgt 5 80.062 ± 3.744 us/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
