saurabhd336 commented on code in PR #8708:
URL: https://github.com/apache/pinot/pull/8708#discussion_r885379303
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -364,9 +384,27 @@ public void addSegment(ImmutableSegment immutableSegment) {
if (isUpsertEnabled()) {
handleUpsert((ImmutableSegmentImpl) immutableSegment);
}
+
+ if (_isDedupEnabled) {
+ buildDedupeMeta((ImmutableSegmentImpl) immutableSegment);
+ }
super.addSegment(immutableSegment);
}
+ private void buildDedupeMeta(ImmutableSegmentImpl immutableSegment) {
Review Comment:
Ack
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -364,9 +384,27 @@ public void addSegment(ImmutableSegment immutableSegment) {
if (isUpsertEnabled()) {
handleUpsert((ImmutableSegmentImpl) immutableSegment);
}
+
+ if (_isDedupEnabled) {
+ buildDedupeMeta((ImmutableSegmentImpl) immutableSegment);
+ }
super.addSegment(immutableSegment);
}
+ private void buildDedupeMeta(ImmutableSegmentImpl immutableSegment) {
+ // TODO(saurabh) refactor commons code with handleUpsert
+ String segmentName = immutableSegment.getSegmentName();
+ Integer partitionGroupId = SegmentUtils
+ .getRealtimeSegmentPartitionId(segmentName, _tableNameWithType,
_helixManager, _primaryKeyColumns.get(0));
+ Preconditions.checkNotNull(partitionGroupId, String
+ .format("PartitionGroupId is not available for segment: '%s'
(upsert-enabled table: %s)", segmentName,
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
