siddharthteotia commented on code in PR #8434:
URL: https://github.com/apache/pinot/pull/8434#discussion_r887172863
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/InstanceAssignmentConfig.java:
##########
@@ -28,29 +28,37 @@
public class InstanceAssignmentConfig extends BaseJsonConfig {
+ @JsonPropertyDescription("Configuration for the instance assignment
strategy")
+ public final Constants.PartitionSelector _partitionSelector;
Review Comment:
Did we consider making this part of `InstanceReplicaGroupPartitionConfig`
itself rather than root `InstanceAssignmentConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
