gortiz commented on code in PR #8818:
URL: https://github.com/apache/pinot/pull/8818#discussion_r888712252
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##########
@@ -255,6 +255,9 @@ private BaseFilterOperator
constructPhysicalOperator(FilterContext filter, int n
|| textIndexReader instanceof NativeMutableTextIndex) {
throw new UnsupportedOperationException("TEXT_MATCH is not
supported on native text index");
}
+ if (textIndexReader == null) {
+ throw new UnsupportedOperationException("TEXT_MATCH is not
supported when there is no text index");
Review Comment:
This moves the correctness check from execution to parsing time, which
should be better, but makes `ExplainPlanQueriesTest` fail.
As indicated by its name, this tests does execute `explain plan` instead of
the actual query. This is why the test didn't fail before. As this PR shouldn't
be related to `text_match` but `regexp_like`, I'm going to remove this change
for simplicity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
