jackjlli commented on code in PR #8753:
URL: https://github.com/apache/pinot/pull/8753#discussion_r894045868
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/HttpSegmentFetcher.java:
##########
@@ -90,6 +92,58 @@ public void fetchSegmentToLocal(URI downloadURI, File dest)
});
}
+ @Override
+ public File fetchUntarSegmentToLocalStreamed(URI downloadURI, File dest,
long maxStreamRateInByte)
+ throws Exception {
+ // Create a RoundRobinURIProvider to round robin IP addresses when retry
uploading. Otherwise may always try to
Review Comment:
I think most of the logic here is the same as the one in
`fetchSegmentToLocal()` method. It'd be good to check if we can extract the
same logic to avoid duplicating the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
