walterddr commented on code in PR #8980:
URL: https://github.com/apache/pinot/pull/8980#discussion_r910429322
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -23,13 +23,13 @@
*/
public class QueryConfig {
public static final String KEY_OF_QUERY_SERVER_PORT =
"pinot.query.server.port";
- public static final int DEFAULT_QUERY_SERVER_PORT = -1;
+ public static final int DEFAULT_QUERY_SERVER_PORT = 0;
public static final String KEY_OF_QUERY_RUNNER_HOSTNAME =
"pinot.query.runner.hostname";
public static final String DEFAULT_QUERY_RUNNER_HOSTNAME = "localhost";
// query runner port is the mailbox port.
public static final String KEY_OF_QUERY_RUNNER_PORT =
"pinot.query.runner.port";
- public static final int DEFAULT_QUERY_RUNNER_PORT = -1;
+ public static final int DEFAULT_QUERY_RUNNER_PORT = 0;
Review Comment:
for now I think we can just leave it since this is a config file. the
comment is already there in QueryRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
