joshigaurava commented on code in PR #8978:
URL: https://github.com/apache/pinot/pull/8978#discussion_r915067201
##########
pinot-controller/src/main/resources/app/pages/InstanceDetails.tsx:
##########
@@ -308,7 +315,7 @@ const InstanceDetails = ({ match }:
RouteComponentProps<Props>) => {
</CustomButton>
<CustomButton
onClick={handleDropAction}
- tooltipTitle="Removes the node from the cluster. Untag &
rebalance (to ensure node is not being used by any table), and shutdown
instance, before dropping."
+ tooltipTitle={!instanceName.startsWith('Minion_') ? "Removes
the node from the cluster. Untag & rebalance (to ensure node is not being used
by any table), and shutdown instance, before dropping." : ""}
Review Comment:
Is there a difference between line 74
```
else if (instanceName.toLowerCase().startsWith('minion')) {
instanceType = 'MINION';
}
```
and the condition here? Could we just use `instanceType === 'MINION'` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
