nizarhejazi commented on code in PR #8927:
URL: https://github.com/apache/pinot/pull/8927#discussion_r917460044
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java:
##########
@@ -40,12 +44,40 @@
public class TransformBlockValSet implements BlockValSet {
private final ProjectionBlock _projectionBlock;
private final TransformFunction _transformFunction;
+ private final RoaringBitmap _nullBitmap;
private int[] _numMVEntries;
- public TransformBlockValSet(ProjectionBlock projectionBlock,
TransformFunction transformFunction) {
+ public TransformBlockValSet(ProjectionBlock projectionBlock,
TransformFunction transformFunction,
+ ExpressionContext expression) {
_projectionBlock = projectionBlock;
_transformFunction = transformFunction;
+ RoaringBitmap nullBitmap = null;
Review Comment:
I went this way because it requires much less plumbing. Let me know if you
feel strongly otherwise.
Also, passing nullHandlingEnabled requires passing QueryContext across many
layers. Happy to do so if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
