Jackie-Jiang commented on code in PR #9063:
URL: https://github.com/apache/pinot/pull/9063#discussion_r923954988
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java:
##########
@@ -158,7 +158,10 @@ public SegmentConversionResult executeTask(PinotTaskConfig
pinotTaskConfig)
new
BasicNameValuePair(FileUploadDownloadClient.QueryParameters.ENABLE_PARALLEL_PUSH_PROTECTION,
"true");
NameValuePair tableNameParameter = new
BasicNameValuePair(FileUploadDownloadClient.QueryParameters.TABLE_NAME,
TableNameBuilder.extractRawTableName(tableNameWithType));
- List<NameValuePair> parameters =
Arrays.asList(enableParallelPushProtectionParameter, tableNameParameter);
+ NameValuePair tableTypeParameter = new
BasicNameValuePair(FileUploadDownloadClient.QueryParameters.TABLE_TYPE,
+
TableNameBuilder.getTableTypeFromTableName(tableNameWithType).toString());
Review Comment:
(code format) Can you please setup the [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#setup-ide)
and reformat the changes
##########
pom.xml:
##########
@@ -166,8 +166,8 @@
To change kafka connector dependency, we only need to update this version
number config.
TODO: figure out a way to inject kafka dependency instead of explicitly
setting the kafka module dependency -->
<kafka.version>2.0</kafka.version>
- <protobuf.version>3.19.2</protobuf.version>
- <grpc.version>1.41.0</grpc.version>
+ <protobuf.version>3.20.1</protobuf.version>
Review Comment:
The version upgrade is irrelevant. Suggest reverting it in case it has some
side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
