rino-kadijk commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r926918621
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##########
@@ -54,19 +57,19 @@ public class JsonAsyncHttpPinotClientTransport implements
PinotClientTransport {
private final Map<String, String> _headers;
private final String _scheme;
- private static final long BROKER_READ_TIMEOUT_MS = 60000L;
- private static final int BROKER_CONNECT_TIMEOUT_MS = 2000;
-
+ private final int _brokerReadTimeout;
private final AsyncHttpClient _httpClient;
public JsonAsyncHttpPinotClientTransport() {
+ _brokerReadTimeout = 60000;
_headers = new HashMap<>();
_scheme = CommonConstants.HTTP_PROTOCOL;
_httpClient = Dsl.asyncHttpClient();
}
public JsonAsyncHttpPinotClientTransport(Map<String, String> headers, String
scheme,
- @Nullable SSLContext sslContext) {
+ @Nullable SSLContext sslContext, int readTimeout, int connectTimeout, int
handshakeTimeout, boolean tlsV10Enabled) {
Review Comment:
I could make it a list, but it might be a bit complicated to pass that as a
JDBC string argument. It might also introduce possible misconfiguration. A list
is more flexible, so I could try to parse it from the connection string. Let me
know what you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
