Jackie-Jiang commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r929366977
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java:
##########
@@ -30,34 +31,48 @@
import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder;
import org.apache.pinot.segment.spi.AggregationFunctionType;
import
org.apache.pinot.segment.spi.index.startree.AggregationFunctionColumnPair;
+import org.roaringbitmap.RoaringBitmap;
-public class CountAggregationFunction implements AggregationFunction<Long,
Long> {
- private static final String COLUMN_NAME = "count_star";
- private static final String RESULT_COLUMN_NAME = "count(*)";
+public class CountAggregationFunction extends
BaseSingleInputAggregationFunction<Long, Long> {
private static final double DEFAULT_INITIAL_VALUE = 0.0;
// Special expression used by star-tree to pass in BlockValSet
private static final ExpressionContext STAR_TREE_COUNT_STAR_EXPRESSION =
ExpressionContext.forIdentifier(AggregationFunctionColumnPair.STAR);
+ private final String _columnName;
+ private final String _resultColumnName;
+ private final boolean _nullHandlingEnabled;
+
+ public CountAggregationFunction(ExpressionContext expression, boolean
nullHandlingEnabled) {
+ super(expression);
+ String expStr = expression.toString();
Review Comment:
Sorry my bad. What I meant is when null handling is **disabled**, we can set
it to `*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
