siddharthteotia commented on code in PR #9143:
URL: https://github.com/apache/pinot/pull/9143#discussion_r935973973
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -48,6 +49,11 @@ public void init()
PinotMailboxGrpc.PinotMailboxStub stub = PinotMailboxGrpc.newStub(channel);
_statusStreamObserver = new MailboxStatusStreamObserver();
_statusStreamObserver.init(stub.open(_statusStreamObserver));
+ // send a begin-of-stream message.
+ _statusStreamObserver.send(MailboxContent.newBuilder()
Review Comment:
Can you elaborate on why this is needed ? As long as the GRPC error is
translated / converted into the error block (METADATA block type in the last
PR) and sent by the sender, it should work just like how you handled other
failures in the last PR https://github.com/apache/pinot/pull/9064/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
