Jackie-Jiang commented on code in PR #9150:
URL: https://github.com/apache/pinot/pull/9150#discussion_r936914895
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -41,21 +40,21 @@ public enum Strategy {
}
@JsonPropertyDescription("Upsert mode.")
- private final Mode _mode;
+ private Mode _mode;
Review Comment:
Consider making `_mode` default to `FULL` and `_hashFunction` default to
`NONE`, which is the most common setup and these 2 fields cannot be `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
