Jackie-Jiang commented on code in PR #9170:
URL: https://github.com/apache/pinot/pull/9170#discussion_r938563108
##########
pinot-common/src/main/java/org/apache/pinot/common/http/MultiGetRequest.java:
##########
@@ -94,7 +95,7 @@ public MultiGetRequest(Executor executor,
HttpConnectionManager connectionManage
* @return instance of CompletionService. Completion service will provide
* results as they arrive. The order is NOT same as the order of URLs
*/
- public CompletionService<GetMethod> execute(List<String> urls, int
timeoutMs) {
+ public CompletionService<GetMethod> execute(List<String> urls, Map<String,
String> requestHeaders, int timeoutMs) {
Review Comment:
```suggestion
public CompletionService<GetMethod> execute(List<String> urls, @Nullable
Map<String, String> requestHeaders, int timeoutMs) {
```
##########
pinot-common/src/main/java/org/apache/pinot/common/http/MultiGetRequest.java:
##########
@@ -94,7 +95,7 @@ public MultiGetRequest(Executor executor,
HttpConnectionManager connectionManage
* @return instance of CompletionService. Completion service will provide
* results as they arrive. The order is NOT same as the order of URLs
*/
- public CompletionService<GetMethod> execute(List<String> urls, int
timeoutMs) {
+ public CompletionService<GetMethod> execute(List<String> urls, Map<String,
String> requestHeaders, int timeoutMs) {
Review Comment:
Let's also keep the original method (without requestHeaders) so that we
don't need to change all the existing usages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
