ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r939457891
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java:
##########
@@ -127,6 +127,13 @@ public ZNRecord toZNRecord() {
return znRecord;
}
+ /**
+ * Returns a new instance of InstancePartitions with the given name
+ */
+ public InstancePartitions withName(String newName) {
Review Comment:
I added this out of an abundance of caution. Was concerned that it might be
easy to run into buggy scenarios in the future where we store an instance
partitions with name `foo` at node `/INSTANCE_PARTITIONS/bar`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
