aidar-st commented on code in PR #9168:
URL: https://github.com/apache/pinot/pull/9168#discussion_r940609526


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -75,6 +75,9 @@ public enum ServerMeter implements AbstractMetrics.Meter {
   INDEXING_FAILURES("attributeValues", true),
   QUERY_HAS_MV_SELECTION_ORDER_BY("queryHasMVSelectionOrderBy", false),
 
+  HEALTHCHECK_OK_CALLS("healthcheck", true),

Review Comment:
   I think it makes more sense to call it "readiness", since there's nothing 
wrong with server during its starting time. So I've renamed it to readiness. 
But I don't fully understand what's the difference between "health" and 
"liveness".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to