ankitsultana commented on code in PR #9199:
URL: https://github.com/apache/pinot/pull/9199#discussion_r943772341
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java:
##########
@@ -88,7 +89,12 @@ public void init(HelixManager helixManager, TableConfig
tableConfig) {
if (_partitionColumn == null) {
LOGGER.info("Initialized OfflineSegmentAssignment with replication: {}
without partition column for table: {} ",
_replication, _offlineTableName);
+ _useDeterministicSegmentAssignment = false;
} else {
+ // TODO: Where do I keep the segment assignment strategy
Review Comment:
Where's the right place to keep the segment assignment strategy constant?
I saw CommonConstants has a SegmentAssignmentStrategyType enum, but it's not
getting used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
