walterddr commented on code in PR #9191:
URL: https://github.com/apache/pinot/pull/9191#discussion_r948457895
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -202,24 +208,21 @@ private BrokerResponseNative handleRequest(long
requestId, String query,
throws Exception {
LOGGER.debug("SQL query for request {}: {}", requestId, query);
- // Compile the request
- long compilationStartTimeNs = System.nanoTime();
+ long compilationStartTimeNs;
PinotQuery pinotQuery;
try {
- if (sqlNodeAndOptions != null) {
- // Include parse time when the query is already parsed
- compilationStartTimeNs -= sqlNodeAndOptions.getParseTimeNs();
- } else {
- sqlNodeAndOptions = CalciteSqlParser.compileToSqlNodeAndOptions(query);
- }
+ // Parse the request
+ sqlNodeAndOptions = sqlNodeAndOptions != null ? sqlNodeAndOptions
+ : RequestUtils.parseQuery(requestId, query, request);
+ // Compile the request into PinotQuery
+ compilationStartTimeNs = System.nanoTime();
Review Comment:
no. the reporting is now using compilationTime + parsingTime as an overall
reporting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
