Jackie-Jiang commented on code in PR #9191:
URL: https://github.com/apache/pinot/pull/9191#discussion_r948529540
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -121,9 +121,17 @@ public String handleGetSql(@QueryParam("sql") String
sqlQuery, @QueryParam("trac
}
private String executeSqlQuery(@Context HttpHeaders httpHeaders, String
sqlQuery, String traceEnabled,
- String queryOptions)
+ @Nullable String queryOptions)
Review Comment:
Seems this is the only required change to be able to parse query options
from the query?
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -137,6 +138,18 @@ String toJsonString()
*/
int getExceptionsSize();
+ /**
+ * set the result table.
+ * @param resultTable result table to be set.
+ */
+ void setResultTable(ResultTable resultTable);
Review Comment:
Let's not add the setter in the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
