gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r950061067
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java:
##########
@@ -80,9 +81,8 @@ public IntermediateResultsBlock() {
/**
* Constructor for selection result.
*/
- public IntermediateResultsBlock(DataSchema dataSchema, Collection<Object[]>
selectionResult) {
+ public IntermediateResultsBlock(DataSchema dataSchema) {
Review Comment:
I understand that. The change is quite large, but it provides type safety at
compile time. For example, now it is clear that
`MinMaxValueBasedSelectionOrderByCombineOperator` or `SelectionOrderByOperator`
require priority queues.
Anyway, I understand that this change is the most subjective one, so I'm
open to change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
