yuanbenson commented on code in PR #9309:
URL: https://github.com/apache/pinot/pull/9309#discussion_r961196682
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/RealtimeSegmentAssignment.java:
##########
@@ -75,6 +74,14 @@
*/
public class RealtimeSegmentAssignment extends BaseSegmentAssignment {
+ @Override
+ protected void setSegmentAssignmentStrategyMap(
Review Comment:
can consider moving this implementation up to be implemented in
`BaseSegmentAssignment` since `OfflineSegmentAssignment` also shares same
implementation and looks like
`SegmentAssignmentStrategyFactory.getSegmentAssignmentStrategy` can handle the
specifics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
