jasperjiaguo commented on PR #9386: URL: https://github.com/apache/pinot/pull/9386#issuecomment-1244772891
> What about `timeOut` during per segment `planNode` creation, that is before `execute` is called and physical operators are created ? Can happen for extremely large number of segments I guess. > > ``` > Plan queryPlan = > enableStreaming ? _planMaker.makeStreamingInstancePlan(selectedSegments, queryContext, executorService, > responseObserver, _serverMetrics) : _planMaker.makeInstancePlan(selectedSegments, queryContext, > executorService, _serverMetrics); > planBuildTimer.stopAndRecord(); > ``` > > ^^ can potentially timeOut > > ``` > TimerContext.Timer planExecTimer = timerContext.startNewPhaseTimer(ServerQueryPhase.QUERY_PLAN_EXECUTION); > DataTable dataTable = queryContext.isExplain() ? processExplainPlanQueries(queryPlan) : queryPlan.execute(); > ``` The work here I think is to do `makeSegmentPlanNode` for each segment to create top level plan nodes, shouldn't be too much work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
