Jackie-Jiang commented on code in PR #9377:
URL: https://github.com/apache/pinot/pull/9377#discussion_r969987494
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ExpressionTransformer.java:
##########
@@ -132,6 +132,7 @@ public GenericRow transform(GenericRow record) {
record.putValue(column,
transformFunctionEvaluator.evaluate(record));
} catch (Exception e) {
record.putValue(column, null);
+ record.putValue(GenericRow.INCOMPLETE_RECORD_KEY, true);
Review Comment:
Let's make this consistent with other transformers and move the if check
into the catch block, and log a debug info. `record.putValue(column, null);` is
redundant
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##########
@@ -163,11 +172,20 @@ private static Map<String, String>
parsePrefixesToRename(TableConfig tableConfig
@Override
public GenericRow transform(GenericRow record) {
- flattenMap(record, new ArrayList<>(record.getFieldToValueMap().keySet()));
- for (String collection : _fieldsToUnnest) {
- unnestCollection(record, collection);
+ try {
Review Comment:
The current way should be fine. I don't remember seeing extra overhead on
try-catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
