Jackie-Jiang commented on code in PR #9385:
URL: https://github.com/apache/pinot/pull/9385#discussion_r970277001
##########
pinot-core/src/test/java/org/apache/pinot/core/common/DataFetcherTest.java:
##########
@@ -221,45 +204,23 @@ public void testFetchBigDecimalValues() {
testFetchBigDecimalValues(FLOAT_COLUMN);
testFetchBigDecimalValues(DOUBLE_COLUMN);
testFetchBigDecimalValues(BIG_DECIMAL_COLUMN);
- testFetchBigDecimalValues(STRING_COLUMN);
testFetchBigDecimalValues(NO_DICT_INT_COLUMN);
testFetchBigDecimalValues(NO_DICT_LONG_COLUMN);
testFetchBigDecimalValues(NO_DICT_FLOAT_COLUMN);
testFetchBigDecimalValues(NO_DICT_DOUBLE_COLUMN);
testFetchBigDecimalValues(NO_DICT_BIG_DECIMAL_COLUMN);
- testFetchBigDecimalValues(NO_DICT_STRING_COLUMN);
}
@Test
public void testFetchStringValues() {
- testFetchStringValues(INT_COLUMN);
- testFetchStringValues(LONG_COLUMN);
- testFetchStringValues(FLOAT_COLUMN);
- testFetchStringValues(DOUBLE_COLUMN);
- testFetchStringValues(BIG_DECIMAL_COLUMN);
testFetchStringValues(STRING_COLUMN);
- testFetchStringValues(NO_DICT_INT_COLUMN);
- testFetchStringValues(NO_DICT_LONG_COLUMN);
- testFetchStringValues(NO_DICT_FLOAT_COLUMN);
- testFetchStringValues(NO_DICT_DOUBLE_COLUMN);
- testFetchStringValues(NO_DICT_BIG_DECIMAL_COLUMN);
Review Comment:
I don't think implicit type cast from other type to STRING is good practice
either, and we have observed performance regression doing it in #9287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
