npawar commented on code in PR #9400:
URL: https://github.com/apache/pinot/pull/9400#discussion_r971371736
##########
pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java:
##########
@@ -85,6 +89,11 @@ public TaskResult run() {
.addPhaseTiming(taskType, MinionQueryPhase.TASK_QUEUEING,
jobDequeueTimeMs - jobInQueueTimeMs,
TimeUnit.MILLISECONDS);
try {
+ if (separateTaskLogs) {
+ LOGGER.info("Routing logs to separate file for task: {}",
_taskConfig.getId());
+ // Setting MDC so that logger can route task logs to a
separate file.
+ MDC.put("taskId", _taskConfig.getId());
Review Comment:
if all tasks running put/remove the same key "taskId" how does it know to
differentiate and not overwrite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
